New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lenovo CNOS Discovery/Logo Update #8332

Merged
merged 15 commits into from Mar 13, 2018

Conversation

Projects
None yet
4 participants
@jackson-tim
Contributor

jackson-tim commented Mar 6, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

jackson-tim added some commits Mar 6, 2018

Update lenovo-cnos.yaml
Left example CPU Usage there.

@kkrumm1 kkrumm1 added the Device 🖥 label Mar 8, 2018

@laf

Thanks for this.

Some comments left in line that need to be addressed, you also need to add test data: https://docs.librenms.org/#Developing/os/Test-Units/#example-workflow

@@ -0,0 +1,476 @@
LENOVO-ENV-MIB DEFINITIONS ::= BEGIN

This comment has been minimized.

@laf

laf Mar 11, 2018

Member

Can you rename this mib to mibs/lenovo/LENOVO-ENV-MIB

@@ -0,0 +1,73 @@
-- LENOVO-SMI-MIB: Lenovo structure of management information

This comment has been minimized.

@laf

laf Mar 11, 2018

Member

Please rename this mib to mibs/lenovo/LENOVO-SMI-MIB

@@ -0,0 +1,104 @@
-- LENOVO-PRODUCTS-MIB: Lenovo product object identifier assignments

This comment has been minimized.

@laf

laf Mar 11, 2018

Member

Please rename this mib to mibs/lenovo/LENOVO-PRODUCTS-MIB

<?xml version="1.0" encoding="UTF-8"?>

This comment has been minimized.

@laf

laf Mar 11, 2018

Member

Please can you compress this svg down. You can use this to do that: https://jakearchibald.github.io/svgomg/

@@ -0,0 +1,12 @@
os: lenovo-cnos

This comment has been minimized.

@laf

laf Mar 11, 2018

Member

You can rename this to cnos as that's the OS name. It doesn't need the vendor before it unless we have duplicates.

You'll need to rename the files naturally.

jackson-tim added some commits Mar 12, 2018

@laf

This comment has been minimized.

Member

laf commented Mar 12, 2018

Just test data now @jackson-tim.

jackson-tim and others added some commits Mar 12, 2018

@laf

laf approved these changes Mar 13, 2018

@laf laf merged commit f55d98a into librenms:master Mar 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@laf

This comment has been minimized.

Member

laf commented Mar 13, 2018

Thanks very much for this :)

One thing to note, you shouldn't do work in your master branch - see our docs for how to work with git.

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 13, 2018

The inspection completed: No new issues

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

device: Added Lenovo CNOS support (librenms#8332)
* Lenovo CNOS Discovery+Logo Update

* Lenovo MIBs

* Update lenovo-cnos.yaml

Left example CPU Usage there.

* Update lenovo-cnos.yaml

* Update lenovo-cnos.yaml

* Update and rename lenovo-cnos.yaml to cnos.yaml

* Rename lenovo-cnos.yaml to cnos.yaml

* Rename Lenovo-Env-MIB.mib to LENOVO-ENV-MIB

* Rename Lenovo-Products-MIB.mib to  LENOVO-PRODUCTS-MIB

* Rename Lenovo-SMI-MIB.mib to LENOVO-SMI-MIB

* Update lenovo.svg

* Create cnos.json

* Create cnos.snmprec

* Update cnos.json

* Update cnos.yaml
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.