New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detection of Axis Network Speaker #8336

Merged
merged 2 commits into from Mar 13, 2018

Conversation

Projects
None yet
5 participants
@priiduonu
Contributor

priiduonu commented Mar 8, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant

This comment has been minimized.

CLAassistant commented Mar 8, 2018

CLA assistant check
All committers have signed the CLA.

@kkrumm1 kkrumm1 added the Device 🖥 label Mar 8, 2018

@laf

This comment has been minimized.

Member

laf commented Mar 11, 2018

Thanks for submitting this, can you please add test data for this:

https://docs.librenms.org/#Developing/os/Test-Units/#example-workflow

@laf laf added the Needs-Info label Mar 11, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 11, 2018

The inspection completed: No new issues

@priiduonu

This comment has been minimized.

Contributor

priiduonu commented Mar 11, 2018

Hopefully I got it right?

@murrant murrant referenced this pull request Mar 12, 2018

Closed

Sane default temperature limits for Axis cameras #8344

1 of 1 task complete

@laf laf merged commit 2e66ed3 into librenms:master Mar 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@laf

This comment has been minimized.

Member

laf commented Mar 13, 2018

Thanks very much :)

@priiduonu priiduonu deleted the priiduonu:feature/axis_speaker branch Mar 13, 2018

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

device: Added detection of Axis Network Speaker (librenms#8336)
* Add detection of Axis Network Speaker

* tests: add test data for Axis C3003 Network Speaker detection
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.