New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module tests update: per module output, only store modules data that are run #8355

Merged
merged 8 commits into from Mar 14, 2018

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Mar 12, 2018

  • Don't save data for modules that were not run
  • Save output for each module and only output the errorred module
  • Full output when phpunit --debug is used

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

murrant added some commits Mar 12, 2018

Save output for each module and only output the errored module.
Also makes it easier to identify modules that were ran.
Clean up json files.
Message when no module data exists.
verbose output when phpunit --debug is used
order by for ports
avoid graphite output in tests
only load module_tables.yaml once

@murrant murrant changed the title from Test data: don't save data for modules that were not run to Module tests improvements: per module output, only store modules data that are run Mar 14, 2018

@murrant murrant changed the title from Module tests improvements: per module output, only store modules data that are run to Module tests update: per module output, only store modules data that are run Mar 14, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 14, 2018

The inspection completed: 2 new issues, 3 updated code elements

@laf laf merged commit 2bcc766 into librenms:master Mar 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:tests-only-valid branch Mar 15, 2018

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

Module tests update: per module output, only store modules data that …
…are run (librenms#8355)

* Test data: don't save data for modules that were not run

* Sometimes mibs are prefixed with +

* Save output for each module and only output the errored module.
Also makes it easier to identify modules that were ran.

* Clean up json files.
Message when no module data exists.

* verbose output when phpunit --debug is used
order by for ports
avoid graphite output in tests
only load module_tables.yaml once

* use explode and strpos instead of regex since it is failing...

* Fix some warnings

* Fix whitespace
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.