New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alert_id to alerts for templates #8368

Merged
merged 3 commits into from Mar 13, 2018

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Mar 13, 2018

Extract alert loading to a function loadAlerts().
Alternative to #8351

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

murrant added some commits Mar 13, 2018

Add alert_id to alerts for templates
Extract alert loading to a function loadAlerts().
Alternative to #8351

@murrant murrant referenced this pull request Mar 13, 2018

Closed

Adding alerts.id to DescribeAlert() json #8351

0 of 1 task complete
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 13, 2018

The inspection completed: 1 updated code elements

@laf

This comment has been minimized.

Member

laf commented Mar 13, 2018

Tested it doesn’t break alerting.

@laf laf merged commit 6b68d5f into librenms:master Mar 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Member

murrant commented Mar 14, 2018

Thanks @laf

@murrant murrant deleted the murrant:alert_id branch Mar 14, 2018

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

alerts: Added alert_id to alerts for templates (librenms#8368)
* Add alert_id to alerts for templates
Extract alert loading to a function loadAlerts().
Alternative to librenms#8351

* Actually add alert_id to $obj

* travis fixes
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.