New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: add support for Moxa EDS-P510A-8PoE #8384

Merged
merged 7 commits into from Mar 19, 2018

Conversation

Projects
None yet
3 participants
@priiduonu
Contributor

priiduonu commented Mar 15, 2018

Support PoE port consumption, SFP module monitoring and power input statuses for Moxa EDS-P510A-8PoE industrial switch.

Add Moxa EDS-P510A-8PoE MIB.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

priiduonu added some commits Mar 15, 2018

newdevice: add support for Moxa EDS-P510A-8PoE
Support PoE port consumption, SFP module monitoring and power input statuses for Moxa EDS-P510A-8PoE industrial switch.
@laf

Some changes needed for this and if you can submit test data that would be ace.

@@ -0,0 +1,4880 @@

This comment has been minimized.

@laf

laf Mar 15, 2018

Member

Can you rename this file to MOXA-EDSP510A8POE-MIB

@@ -14,3 +18,61 @@ modules:
descr: 'Power Consumption'
index: 'powerConsumption.{{ $index }}'
value: powerConsumption
-
oid: MOXA-EDSP510A8POE-MIB::poePortConsumption

This comment has been minimized.

@laf

laf Mar 15, 2018

Member

This should just be oid: poePortConsumption

Add MOXA-EDSP510A8POE-MIB at the top like:

mib: MOXA-EDSP510A8POE-MIB

This comment has been minimized.

@laf

laf Mar 15, 2018

Member

goes for all the others in this file.

oid: MOXA-EDSP510A8POE-MIB::power1InputStatus
num_oid: .1.3.6.1.4.1.8691.7.86.1.10.1.
descr: 'Power Input 1 Status'
index: 'powerInputStatus.1'

This comment has been minimized.

@laf

laf Mar 15, 2018

Member

May as well change this to index: 'powerInputStatus.{{ $index }}'

This comment has been minimized.

@priiduonu

priiduonu Mar 15, 2018

Contributor

Input 1 and Input 2 have different OID-s and both have index 0 so it probably won't work.

oid: MOXA-EDSP510A8POE-MIB::power2InputStatus
num_oid: .1.3.6.1.4.1.8691.7.86.1.10.2.
descr: 'Power Input 2 Status'
index: 'powerInputStatus.2'

This comment has been minimized.

@laf

laf Mar 15, 2018

Member

Same here

priiduonu added some commits Mar 15, 2018

Update moxa-etherdevice.yaml
Moved MIB definitions to the top as proposed by @laf
@priiduonu

Thanks for the review!

@laf

This comment has been minimized.

Member

laf commented Mar 15, 2018

priiduonu added some commits Mar 16, 2018

@priiduonu

This comment has been minimized.

Contributor

priiduonu commented Mar 16, 2018

Added test data.

@laf

Sorry, last thing. Can you rename the MIB file to MOXA-EDSP510A8POE-MIB

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 17, 2018

The inspection completed: No new issues

@priiduonu

This comment has been minimized.

Contributor

priiduonu commented Mar 17, 2018

Renamed the MIB file.

@laf

laf approved these changes Mar 19, 2018

LGTM. Many thanks @priiduonu :)

@laf laf merged commit f68f4b2 into librenms:master Mar 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@priiduonu priiduonu deleted the priiduonu:patch-2 branch Mar 19, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.