New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LDAP filters for getUserlist and getUserlevel #8398

Merged
merged 1 commit into from Mar 20, 2018

Conversation

Projects
None yet
6 participants
@jclong83
Contributor

jclong83 commented Mar 16, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

~/repos/librenms $ ./scripts/pre-commit.php
Running unit tests... success
Running style check... success
Running lint check... success
Tests ok, submit away :)

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant

This comment has been minimized.

CLAassistant commented Mar 16, 2018

CLA assistant check
All committers have signed the CLA.

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 16, 2018

The inspection completed: 1 new issues, 1 updated code elements

@murrant

This comment has been minimized.

Member

murrant commented Mar 19, 2018

This seems reasonable to me, hopefully someone with ldap can test.

@laf

laf approved these changes Mar 19, 2018

LGTM

@davama

This comment has been minimized.

davama commented Mar 20, 2018

Tested PR
Was able to still log in using ldap credentials

@laf laf merged commit aefc224 into librenms:master Mar 20, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@lock lock bot locked as resolved and limited conversation to collaborators May 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.