Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Sentry4 sensor discovery #8407

Merged
merged 6 commits into from Mar 29, 2018

Conversation

Projects
None yet
4 participants
@Rosiak
Copy link
Contributor

Rosiak commented Mar 16, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Should address #8031.

I have not processed:
st4Outlets
st4TemperatureSensors
st4HumiditySensors
st4WaterSensors
st4ContactClosureSensors
st4AnalogToDigitalConvSensors
st4FanSensors
st4EventInformation

I have not added test data either, as the data I tested was from one of the issues, hence not mine.

Indexes will change for frequency and power, so data will be lost.

@laf

This comment has been minimized.

Copy link
Member

laf commented Mar 17, 2018

We can just set the new index to be the same as the old, better to do that and preserve historical data than just wipe it out.

@dev9null dev9null referenced this pull request Mar 21, 2018

Closed

Updating ServerTech PDU device support #8031

5 of 5 tasks complete

@laf laf added the Device 🖥 label Mar 21, 2018

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Mar 21, 2018

The inspection completed: No new issues

@laf

This comment has been minimized.

Copy link
Member

laf commented Mar 21, 2018

This is now ready I'd like someone else to take a look as it changes the way user_functions are called. Before we processed them before we ran divisor/multiplier which would then cause bad data.

For example, Fahrenheit to celsius where the value also needed to be divided by first resulted in the wrong values.

So, actually run the function once we have the correct known value.

@murrant murrant merged commit 8ec70a9 into librenms:master Mar 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant changed the title feature: Improve Sentry4 discovery Improve Sentry4 discovery Mar 29, 2018

@murrant murrant changed the title Improve Sentry4 discovery Improve Sentry4 sensor discovery Mar 29, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

Improve Sentry4 discovery (librenms#8407)
* feature: Improve Sentry4 discovery

* Added test data

* Updated to take into account C/F conversion

* fixed test json data

@lock lock bot locked as resolved and limited conversation to collaborators May 28, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.