New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check_haproxy service configuration #8412

Merged
merged 3 commits into from Mar 18, 2018

Conversation

Projects
None yet
3 participants
@HomeServ
Contributor

HomeServ commented Mar 18, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

HomeServ added some commits Mar 18, 2018

Added check_haproxy service configuration.
Default configuration had -H option which isn't supported by the nagios check_haproxy plugin.
Added check_haproxy service configuration.
Default configuration had -H option which isn't supported by the nagios check_haproxy plugin.
Added check_haproxy service configuration.
Default configuration had -H option which isn't supported by the nagios check_haproxy plugin.
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 18, 2018

The inspection completed: No new issues

@laf

laf approved these changes Mar 18, 2018

LGTM

@laf laf merged commit 7dfd0a3 into librenms:master Mar 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

feature: Added check_haproxy service configuration (librenms#8412)
* Added check_haproxy service configuration.
Default configuration had -H option which isn't supported by the nagios check_haproxy plugin.

* Added check_haproxy service configuration.
Default configuration had -H option which isn't supported by the nagios check_haproxy plugin.

* Added check_haproxy service configuration.
Default configuration had -H option which isn't supported by the nagios check_haproxy plugin.
@lock

This comment has been minimized.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.