New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom phpcs ruleset for LibreNMS #8418

Merged
merged 5 commits into from Mar 20, 2018

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Mar 19, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

murrant added some commits Mar 19, 2018

* @param array $excludes array of directories to exclude
* @return string resulting string
*/
function build_excludes($exclude_string, $excludes)

This comment has been minimized.

@laf

laf Mar 19, 2018

Member

You can't remove this, it's still used:

$lint_exclude = build_excludes('--exclude ', $lint_excludes);

This comment has been minimized.

@murrant

murrant Mar 19, 2018

Member

Whiopsie

murrant added some commits Mar 20, 2018

Restore build_excludes()
Drop influxdb lib exclusion
@laf

laf approved these changes Mar 20, 2018

LGTM

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 20, 2018

The inspection completed: No new issues

@laf laf merged commit 8c94ccf into librenms:master Mar 20, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:phpcs_ruleset branch Mar 20, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.