New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed and improved toner discovery #8428

Merged
merged 2 commits into from Mar 29, 2018

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Mar 20, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #8329

It doesn't break the device for which this fix was originally added for and the fix really shouldn't have been done. Working round one vendors bad implementation.

Also dropped walking of unneeded OIDs as these were just indexes so walk data we actually use.

Update konica data
xerox tries to insert too long of descriptions.  Lets remove the part and serial number, they are ugly to look at in the ui.
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 23, 2018

The inspection completed: No new issues

@laf

This comment has been minimized.

Member

laf commented Mar 23, 2018

Any downside to leaving the PN in though @murrant ?

@murrant

This comment has been minimized.

Member

murrant commented Mar 23, 2018

@laf SQL fails because the input is too long. I also assume that long of a string would look bad in the webui.

@murrant murrant merged commit 07ee21b into librenms:master Mar 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:fix/issue-8329 branch Mar 29, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

fix: Fixed and improved toner discovery (librenms#8428)
* fix: Fixed and improved toner discovery

* Update konica data
xerox tries to insert too long of descriptions.  Lets remove the part and serial number, they are ugly to look at in the ui.

@lock lock bot locked as resolved and limited conversation to collaborators May 28, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.