Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Small improvement to per port polling #8431

Merged
merged 1 commit into from Mar 22, 2018

Conversation

Projects
None yet
3 participants
@laf
Copy link
Member

laf commented Mar 21, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Small improvement. I think the ports polling needs love overall but this just shifts what we already do into per port polling to save some time.

For a device I have (eos), it's had a 20% saving on poll time (100 -> 80~)

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Mar 21, 2018

The inspection completed: No new issues

@murrant murrant merged commit faf4831 into librenms:master Mar 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:refactor/dot3-ports branch Mar 23, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 22, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.