New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP debug output #8434

Merged
merged 2 commits into from Mar 29, 2018

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Mar 21, 2018

Updated LDAP and AD docs
ldap protocol default to v3 (so we don't have to set it all the time). If this fails it should revert to v2.
ad was using auth_ad_timeout incorrectly (1 I think)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

LDAP debug
Updated LDAP and AD docs
ldap protocol default to v3 (so we don't have to set it all the time).  If this fails it should revert to v2.
ad was using auth_ad_timeout incorrectly (1 I think)

@murrant murrant added the Enhancement label Mar 22, 2018

@murrant murrant changed the title from LDAP debug to LDAP debug output Mar 22, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 29, 2018

The inspection completed: 1 updated code elements

@laf

laf approved these changes Mar 29, 2018

LGTM

@laf laf merged commit 5c83aa1 into librenms:master Mar 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:ldap_debug branch Mar 29, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

refactor: LDAP debug output (librenms#8434)
* LDAP debug
Updated LDAP and AD docs
ldap protocol default to v3 (so we don't have to set it all the time).  If this fails it should revert to v2.
ad was using auth_ad_timeout incorrectly (1 I think)

* Add option to list all users.

@lock lock bot locked as resolved and limited conversation to collaborators May 28, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.