New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation sql for primary keys and first columns #8453

Merged
merged 2 commits into from Mar 23, 2018

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Mar 22, 2018

Remove extra space in generated sql :D

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

murrant and others added some commits Mar 22, 2018

Fix validation sql for primary keys and first columns
Remove extra space in generated sql :D
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 22, 2018

The inspection completed: 1 updated code elements

@laf

laf approved these changes Mar 23, 2018

LGTM

@laf laf merged commit 0c0a70c into librenms:master Mar 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:validate-primary-key branch Mar 23, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 22, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.