New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devices: Add Phybridge OS support #8456

Merged
merged 11 commits into from Mar 29, 2018

Conversation

Projects
None yet
4 participants
@vivia11
Contributor

vivia11 commented Mar 23, 2018

Hello,
Adding support for NVT Phybridge.
Tested with a Flex Switch.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@murrant

You need to minimize your svg files and the icon should be inverted I think.
https://jakearchibald.github.io/svgomg/

vivia11 and others added some commits Mar 26, 2018

@laf

This comment has been minimized.

Member

laf commented Mar 26, 2018

I've just pushed the json test data needed for this.

however, the OS name is just the company name when it should be named after the firmware of the device. What is that name? If it doesn't have one then it should closely resemble the product name.

@vivia11

This comment has been minimized.

Contributor

vivia11 commented Mar 26, 2018

@laf
From what I can gather the software version is: "SYS 3.1.9 PKG 7.0.0". Not sure if SYS or PKG is the name...
The model name is Flex Switch - 24 Port.

Should I rename the files/os to sys | pkg | flex?

@laf

This comment has been minimized.

Member

laf commented Mar 27, 2018

Looks like it might be better as phybridge-flex

@vivia11

This comment has been minimized.

Contributor

vivia11 commented Mar 27, 2018

Okay I renamed the OS to phybridge-flex. Let me know if I'm missing something or if I should rename anything else.

vivia11 and others added some commits Mar 28, 2018

@murrant

Thanks for updating

@murrant murrant added the Device 🖥 label Mar 29, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 29, 2018

The inspection completed: No new issues

@murrant murrant merged commit 314a552 into librenms:master Mar 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@vivia11 vivia11 deleted the vivia11:phybridge-os branch Mar 29, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

devices: Add Phybridge OS support (librenms#8456)
* OS yaml definition for Phybridge

* Add images and snmp data

* Removed width/height from svg and added more specific discovery for phybridge

* Minimized svg and inverted icon

* added json test file

* update to json file

* Changing os name: phybridge to phybridge-flex

* Update json file to phybridge-flex

* Remove unneeded test data

@lock lock bot locked as resolved and limited conversation to collaborators May 28, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.