New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default alert delay to 1m #8462

Merged
merged 1 commit into from Mar 29, 2018

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Mar 23, 2018

Add regex type for numbers
Tooltips for all alert rule dialog items
Remove spaces in time settings.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Change the default alert delay to 1m
Add regex type for numbers
Tooltips for all alert rule dialog items
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 23, 2018

The inspection completed: No new issues

@laf

laf approved these changes Mar 23, 2018

LGTM although not sure we need to duplicate the tool tips.

@murrant

This comment has been minimized.

Member

murrant commented Mar 26, 2018

@laf The reason for the duplicate tooltips was I wanted the tooltip on both parts of the field, but we break the field up because of the html structure.

I could probably try to restructure the html.

@murrant murrant merged commit d91fe84 into librenms:master Mar 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:new-alert-improvements branch Mar 29, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

Change the default alert delay to 1m (librenms#8462)
Add regex type for numbers
Tooltips for all alert rule dialog items

@lock lock bot locked as resolved and limited conversation to collaborators May 28, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.