New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tegile Storage OS detection, storage pool, and project storage. #8464

Merged
merged 37 commits into from Apr 9, 2018

Conversation

Projects
None yet
4 participants
@theherodied
Contributor

theherodied commented Mar 23, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #7921

@theherodied theherodied referenced this pull request Mar 23, 2018

Closed

Add Support For Tegile IntelliFlash #7921

5 of 5 tasks complete
@theherodied

This comment has been minimized.

Contributor

theherodied commented Mar 23, 2018

Don't approve this yet. It's a work in progress. I just want testers to try it.

theherodied added some commits Mar 23, 2018

Revert "Trying dedup 007"
This reverts commit b30a3ed.

@theherodied theherodied changed the title from added Tegile Storage 001 to Added Tegile Storage OS detection and basic storage pool support Mar 24, 2018

@theherodied

This comment has been minimized.

Contributor

theherodied commented Mar 24, 2018

This is ready to merge. Tegile OS detection and pool usage has been added.
More will be added in a future PR.

@laf laf added the Device 🖥 label Mar 25, 2018

@laf

This comment has been minimized.

Member

laf commented Mar 25, 2018

Thanks for this @theherodied.

Is tegile the correct os name? It should be based on the firmware / OS it's actually running so should this be IntelliFlash instead?

@theherodied

This comment has been minimized.

Contributor

theherodied commented Mar 25, 2018

@laf, I went back and forth on that from what I saw in the disco and poller. I can update it but how would you want it named?

They call it Tegile IntelliFlash in the snmp output.

Just intelliflash all lowercase?

theherodied added some commits Mar 26, 2018

@theherodied

This comment has been minimized.

Contributor

theherodied commented Mar 26, 2018

@laf, let me know how this is now.
I didn't change the icon name as it's really the Tegile Logo I believe. I also left the mib directory as tegile/TEGILE-MIB. I left the mib named as they have it in the actual mib file itself.

laf and others added some commits Mar 26, 2018

@@ -34,9 +34,40 @@
//Tegile uses a high 32bit counter and a low 32bit counter to make a 64bit counter. Size units are in bytes

This comment has been minimized.

@murrant

murrant Mar 29, 2018

Member

Can you wrap this file with an if($device['os'] = 'intelliflash') check? I know it is silly, but a quick fix for now.

@theherodied

This comment has been minimized.

Contributor

theherodied commented Mar 29, 2018

Think this is ready to be merged. More can be added in the future such as interface usage.

@theherodied theherodied changed the title from Added Tegile Storage OS detection and basic storage pool support to Added Tegile Storage OS detection, storage pool, and project storage. Mar 29, 2018

@laf

Couple of changes from me then it looks good.

- tegile
discovery:
- sysDescr:
- Tegile IntelliFlash

This comment has been minimized.

@laf

laf Apr 1, 2018

Member

Looks like you can use sysObjectID instead for detection. From our stats .1.3.6.1.4.1.43906.1 is unique to this device. sysObjectID is more stable for detection.

* @author https://github.com/theherodied/
*/
use LibreNMS\Config;
if($device['os'] = 'intelliflash') {

This comment has been minimized.

@laf

laf Apr 1, 2018

Member

= will always match here :) Should be ==

@laf laf dismissed their stale review via c9b1547 Apr 2, 2018

@laf

This comment has been minimized.

Member

laf commented Apr 2, 2018

Test data updated, hopefully that fixes travis.

@murrant

This comment has been minimized.

Member

murrant commented Apr 6, 2018

Storage units is not set (you need to set it to 1) and the SQL is failing, that is why tests fail.

@theherodied

This comment has been minimized.

Contributor

theherodied commented Apr 8, 2018

Fixes: #7921

laf added some commits Apr 8, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Apr 8, 2018

The inspection completed: No new issues

@murrant

murrant approved these changes Apr 9, 2018

@murrant murrant merged commit 313b462 into librenms:master Apr 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

Added Tegile Storage OS detection, storage pool, and project storage. (
…librenms#8464)

* added Tegile Storage 001

* Tegile fixed whitespace 002

* Added tegile.snmprec 003

* Added TEGILE-MIB

* Tried to fix svg size issue

* Tried to fix svg size issue 005

* Tried to fix svg size issue 006

* Trying dedup 007

* Revert "Trying dedup 007"

This reverts commit b30a3ed.

* Tried to fix svg size issue 009

* Tried to fix svg size issue 010

* Reverted changes and created new branch

* changed tegile to intelliflash

* changed tegile to intelliflash

* changed tegile to intelliflash 002

* added intelliflash snmprec

* added Json test data

* Update intelliflash.json

* Redid logo

* Update tegile.svg

* changed to intelliflash1. intelliflash2 will come later.

* removed previous commit I made

* Adding project usage

* simplified project calculations

* simplified project calculations

* simplified project calculations

* simplified project calculations

* Cleaned up comments

* Added disco OS if check and removed network over graph

* chenged os detection to sysObjectID. Fixed disco if check.

* Updated json test file

* Fixed intelliflash-pr storage units.

* Updated test data

* Updated test data to remove bgp module

@lock lock bot locked as resolved and limited conversation to collaborators Jun 8, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.