New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow on to PR 8168 - Fixed merge of manage_bills.php #8467

Merged
merged 17 commits into from Mar 29, 2018

Conversation

Projects
None yet
3 participants
@rucarrol
Contributor

rucarrol commented Mar 24, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Running unit tests... success
Running style check... success
Running lint check... success
Tests ok, submit away :) 

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 24, 2018

The inspection completed: 2 new issues, 1 updated code elements

@murrant murrant merged commit 665229b into librenms:master Mar 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

Follow on to PR 8168 - Fixed merge of manage_bills.php (librenms#8467)
* Adding 1st rev of manage_bills.php

* Stlye fixes

* Freshinging PR 7633. Changing -r to -f, to be less confusing. Adding code style changes as per @laf's suggesting

* Adding in option for sysname or hostname variable. Fixing hostname lookup bug

* style fixes

* -renaming add_ports to add_ports_to_bill
- changing -i to -b for clarity sake
- Will print help if -s and -h are not set

* Adding check to ensure -i is set via cli

* I'm stupid

* I'm stupid

* Fixing help messages, fixing argument checking, moving help to it's own function

* Adding create_bill functionality, update help and opts as needed

* Adding 1st rev of manage_bills.php

* Stlye fixes

* Freshinging PR 7633. Changing -r to -f, to be less confusing. Adding code style changes as per @laf's suggesting

* Adding check to ensure -i is set via cli

* I'm stupid

@lock lock bot locked as resolved and limited conversation to collaborators May 28, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.