New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebranding of Avaya BOSS and VOSS to Extreme #8469

Merged
merged 73 commits into from Apr 21, 2018

Conversation

Projects
None yet
4 participants
@ospfbgp
Contributor

ospfbgp commented Mar 25, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

ospfbgp added some commits Mar 25, 2018

Update avaya-ers.yaml
Extreme bought avaya network assests so rebranding and moving some files.
Add files via upload
Extreme bought avaya networking assets and so rebranding to Extreme and adding logos with OS for easier reading when on devices pages
Update avaya-vsp.yaml
removing .1.3.6.1.4.1.45.3.79.1  This is a VSP 7024xl from avaya.  This is techincally not VOSS but BOSS operating system.  It should be in BOSS and avaya-ers.yaml
@ospfbgp

This comment has been minimized.

Contributor

ospfbgp commented Mar 25, 2018

boss-7024-screenshot

voss-screenshot

Since Extreme bought the networking assets from Avaya they need to have new logos/images for products. The products are VOSS and BOSS operating systems. I have created new logos for easy viewing on devices pages. I put VOSS and BOSS below Extreme images. I also removed an OID for a device from VOSS(avaya-vsp.yaml). The device is .1.3.6.1.4.1.45.3.79.1 (VSP 7024XLS). Even though it is call VSP it is a BOSS/(Ethernet routing switch). I have fixed this and done testing. I have included screenshots of the devices pages. This is phase 1 of BOSS rework.

@laf

You need to compress the svg's: https://jakearchibald.github.io/svgomg/

We should also update the actual os names to be in line with what they actually are.

@ospfbgp

This comment has been minimized.

Contributor

ospfbgp commented Mar 25, 2018

laf. I went to the link, uploaded the files and now the svg files are 523 bytes and 520 bytes. I hope this is ok now.

BOSS/VOSS os history
Extreme Ethernet Routing Switch(ERS) use the BOSS(Baystack operating system software). This is all the old Synoptics/Nortel/Avaya switches called Ethernet Routing Switch/Ethernet Switch. There was a single VSP(Virtual Switch Platform) that used the BOSS and it was the VSP-7024. I have no idea why they did this other than marketing. It made no sense IMO. All Avaya/Extreme VSP use the VOSS(VSP operating system software).

Do you want me to change the following files for avaya-ers? If so do you want me to make them extreme-boss or extreme-ers?
./discovery/vlans/avaya-ers.inc.php
./discovery/mempools/avaya-ers.inc.php
./discovery/sensors/temperature/avaya-ers.inc.php
./discovery/sensors/state/avaya-ers.inc.php
./polling/os/avaya-ers.inc.php
./polling/mempools/avaya-ers.inc.php
./definitions/avaya-ers.yaml

Do you want me to change the following files for avaya-vsp? If so do you want me to make them extreme-vsp or extreme-voss?
./discovery/mempools/avaya-vsp.inc.php
./discovery/sensors/temperature/avaya-vsp.inc.php
./discovery/sensors/state/avaya-vsp.inc.php
./polling/os/avaya-vsp.inc.php
./polling/mempools/avaya-vsp.inc.php
./definitions/discovery/avaya-vsp.yaml
./definitions/avaya-vsp.yaml

ospfbgp added some commits Mar 27, 2018

@ospfbgp

This comment has been minimized.

Contributor

ospfbgp commented Mar 27, 2018

I have renamed the files from avaya-ers -> extreme-boss and avaya-vsp -> extreme-voss. I have also updated all the files to reflect the new reference.

@murrant

This comment has been minimized.

Member

murrant commented Mar 29, 2018

How about renaming them to ers, voss, and boss? or ers, vsp, baystack?

@ospfbgp

This comment has been minimized.

Contributor

ospfbgp commented Mar 29, 2018

So here is the breakdown.

BOSS = ERS3XXX, ERS4xxx, ERS5xxx, VSP7024XX
This includes the Nortel and Avaya ERS platform. The OS for these platforms has always been called BOSS and uses the same mibs for fans, cpu, memory, temperature.

VOSS = VSP44xx, VSP48XX, VSP72XX, VSP82XX, VSP84XX, VSP86XX, VSP88XX
All VOSS use the same mibs for fans, cpu, memory, temperature

Extreme bought all the networkings assets and that includes the ERS and VOSS from Avaya.

I feel it would be very difficult to categorize these into ERS, VOSS, and BOSS. ERS and BOSS are going to share the same mibs. ERS and BOSS would end up being very similar from a management perspective. I can get a list of system OID that fit BOSS exactly if needed but I think just making it BOSS would not be easier and more clear. Any recent products over the last 7-8 years fall into the BOSS and VOSS. Avaya/Nortel end of life and end of support all the ES platform, ERS86xx, and ERS88xx. You can not even get parts for these platforms without going through a third party.

@murrant

This comment has been minimized.

Member

murrant commented Mar 29, 2018

So, you want just boss and voss? Sounds ok to me. I was just saying there is no reason to include the company name in the os. We do that in the description.

ospfbgp added some commits Mar 29, 2018

@ospfbgp

This comment has been minimized.

Contributor

ospfbgp commented Mar 29, 2018

All fixed with VOSS and BOSS

ospfbgp added some commits Apr 7, 2018

@ospfbgp

This comment has been minimized.

Contributor

ospfbgp commented Apr 7, 2018

I have updated tests/snmpsim and tests/data.

@laf

I've submitted a notification to merge this on the 12th.

@laf laf added the Blocker 🚫 label Apr 7, 2018

@laf

This comment has been minimized.

Member

laf commented Apr 15, 2018

@ospfbgp I can't merge this at present as the unit tests are failing. Can you rebase against master.

@ospfbgp

This comment has been minimized.

Contributor

ospfbgp commented Apr 15, 2018

@ospfbgp

This comment has been minimized.

Contributor

ospfbgp commented Apr 17, 2018

I have rebased I believe. I am close. I should be up to date now. Let me know if note but I am very close.

Cox-MacBook-Pro:librenms danielcox$ git remote -v
origin https://github.com/ospfbgp/librenms (fetch)
origin https://github.com/ospfbgp/librenms (push)
upstream https://github.com/librenms/librenms.git (fetch)
upstream https://github.com/librenms/librenms.git (push)
Cox-MacBook-Pro:librenms danielcox$ git rebase master
Current branch master is up to date.

@laf

This comment has been minimized.

Member

laf commented Apr 17, 2018

Ok I think it's failing due to LibreNMS/OS/AvayaErs.php. Need to rename that file + the function within it.

$this->getName(), will probably need updating to avaya-ers so old data isn't lost

@ospfbgp

This comment has been minimized.

Contributor

ospfbgp commented Apr 17, 2018

updated let me know if it works. I did not know the processor discovery was there. I was wondering where it was for the boss because it worked. I know when I did processor for voss I put processor discover in /librenms/includes/definitions/discovery

@laf

This comment has been minimized.

@ospfbgp

This comment has been minimized.

Contributor

ospfbgp commented Apr 17, 2018

A lot of little changes. Always the little things.
Thanks for you patience.. :-)

murrant added some commits Apr 20, 2018

@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" version="1" width="100" height="100"><g clip-rule="evenodd" fill="#6502a2" fill-rule="evenodd" stroke-width="1.46"><path d="M95 16.04V0H4.918v63.96l19.303-16.04V16.04z"/><path d="M82.131 47.92V31.882H43.286v16.04zM24.221 80H95V63.96H4.918z"/></g><text style="line-height:1.25;text-orientation:upright" x="20.998" y="102.9" transform="scale(1.03945 .96205)" font-size="25.268" letter-spacing="0" word-spacing="0" fill="#6502a2"><tspan x="20.998" y="102.9">BOSS</tspan></text></svg>

This comment has been minimized.

@murrant

murrant Apr 20, 2018

Member

You need to drop length/width and add viewbox so SVGs render properly in IE. Thanks

@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" version="1" width="100" height="100"><g clip-rule="evenodd" fill="#6502a2" fill-rule="evenodd" stroke-width="1.46"><path d="M95 16.04V0H4.918v63.96l19.303-16.04V16.04z"/><path d="M82.131 47.92V31.882H43.286v16.04zM24.221 80H95V63.96H4.918z"/></g><text style="line-height:1.25;text-orientation:upright" x="23.541" y="101.295" transform="scale(1.02324 .9773)" font-size="24.874" letter-spacing="0" word-spacing="0" fill="#6502a2"><tspan x="23.541" y="101.295">VOSS</tspan></text></svg>

This comment has been minimized.

@murrant

murrant Apr 20, 2018

Member

You need to drop length/width and add viewbox so SVGs render properly in IE. Thanks

laf added some commits Apr 21, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Apr 21, 2018

The inspection completed: 1 new issues, 2 updated code elements

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Apr 21, 2018

The inspection completed: 1 new issues, 2 updated code elements

@laf

laf approved these changes Apr 21, 2018

LGTM. Was supposed to be merged a week ago :(

@laf laf merged commit 9a420a6 into librenms:master Apr 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@ospfbgp

This comment has been minimized.

Contributor

ospfbgp commented Apr 21, 2018

Thank you for all the help.

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

device: Rebranding of Avaya BOSS and VOSS OS' (librenms#8469)
* Update avaya-ers.yaml

Extreme bought avaya network assests so rebranding and moving some files.

* Add files via upload

Extreme bought avaya networking assets and so rebranding to Extreme and adding logos with OS for easier reading when on devices pages

* Update avaya-vsp.yaml

removing .1.3.6.1.4.1.45.3.79.1  This is a VSP 7024xl from avaya.  This is techincally not VOSS but BOSS operating system.  It should be in BOSS and avaya-ers.yaml

* Add files via upload

* Update and rename avaya-vsp.inc.php to extreme-voss.inc.php

* Update and rename avaya-vsp.inc.php to extreme-voss.inc.php

* Update and rename avaya-vsp.inc.php to extreme-voss.inc.php

* Update extreme-voss.inc.php

* Rename avaya-vsp.inc.php to extreme-voss.inc.php

* Rename avaya-vsp.inc.php to extreme-voss.inc.php

* Rename avaya-vsp.yaml to extreme-voss.yaml

* Update and rename avaya-vsp.yaml to extreme-voss.yaml

* Update avaya-ers.yaml

* Rename avaya-ers.yaml to extreme-boss.yaml

* Rename avaya-ers.inc.php to extreme-boss.inc.php

* Update and rename avaya-ers.inc.php to extreme-boss.inc.php

* Update and rename avaya-ers.inc.php to extreme-boss.inc.php

* Update and rename avaya-ers.inc.php to extreme-boss.inc.php

* Update and rename avaya-ers.inc.php to extreme-boss.inc.php

* Update and rename avaya-ers.inc.php to extreme-boss.inc.php

* Update extreme-boss.yaml

* Update extreme-voss.yaml

* Update and rename extreme-boss.yaml to boss.yaml

* Update extreme-voss.yaml

* Rename extreme-voss.yaml to voss.yaml

* Rename extreme-boss.inc.php to boss.inc.php

* Rename extreme-voss.inc.php to voss.inc.php

* Rename extreme-boss.inc.php to boss.inc.php

* Rename extreme-voss.inc.php to voss.inc.php

* Update and rename extreme-voss.inc.php to voss.inc.php

* Rename extreme-voss.yaml to voss.yaml

* Rename extreme-voss.inc.php to voss.inc.php

* Update and rename extreme-voss.inc.php to voss.inc.php

* Update and rename extreme-boss.inc.php to boss.inc.php

* Update and rename extreme-boss.inc.php to boss.inc.php

* Update and rename extreme-boss.inc.php to boss.inc.php

* Rename extreme-boss.inc.php to boss.inc.php

* Update voss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update voss.inc.php

* Update voss.inc.php

* Update voss.inc.php

* Update voss.inc.php

* Update voss.inc.php

* Update voss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update voss.inc.php

* Update boss.inc.php

* Update voss.inc.php

* Update voss.inc.php

* Rename avaya-vsp_8404c.snmprec to voss_8404c.snmprec

* Rename avaya-vsp_8404.snmprec to voss_8404.snmprec

* Rename avaya-vsp_8284xsq.snmprec to voss_8284xsq.snmprec

* Rename avaya-vsp_7254xtq.snmprec to voss_7254xtq.snmprec

* Rename avaya-vsp_7254xsq.snmprec to voss_7254xsq.snmprec

* Rename avaya-vsp_7024xls.snmprec to boss_7024xls.snmprec

* Rename avaya-vsp_4850gts.snmprec to voss_4850gts.snmprec

* Rename avaya-vsp_4850gts-pwr.snmprec to voss_4850gts-pwr.snmprec

* Rename avaya-vsp_4450gsx-pwr.snmprec to voss_4450gsx-pwr.snmprec

* Rename avaya-ers.snmprec to boss.snmprec

* Rename avaya-ers_1.snmprec to boss_1.snmprec

* Update and rename avaya-ers.json to boss.json

* Update and rename avaya-vsp_8404.json to voss_8404.json

* Update and rename avaya-vsp_8404c.json to voss_8404c.json

* Update and rename AvayaErs.php to Boss.php

* Update Boss.php

* Restore processor_type to avaya-ers in test data

* Update voss_8404c.json

* Update extremeboss.svg

* Update extremevoss.svg

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.