New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Add Last Mile CTM support #8478

Merged
merged 6 commits into from Apr 8, 2018

Conversation

Projects
None yet
4 participants
@pheinrichs
Contributor

pheinrichs commented Mar 27, 2018

This PR adds support for Lastmile Gear CTM.
Please review the custom state polling I've added.

Thanks!

The blocker is in place as I'm waiting to see if there is a newer MIB from the manufacturer.
Update: This is the newest MIB available. Custom MIB will easiest solution. For now

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

pheinrichs added some commits Mar 27, 2018

Add Listmile mibs
Created custom lastmile mib
@murrant

This comment has been minimized.

Member

murrant commented Mar 29, 2018

@pheinrichs what is this device. It appears to be a rebranded Cambium Canopy? Or is it just custom firmware?

@pheinrichs

This comment has been minimized.

Contributor

pheinrichs commented Mar 29, 2018

@murrant It is a GPS timing device.It is a custom firmware indeed. None of the cambium mibs / oid's would work.

@murrant

This comment has been minimized.

Member

murrant commented Mar 29, 2018

I mean the mib looks like a copy if the canopy mib.

Ok, gps satellites does not belong in the wireless clients stat. You can either create a custom graph or omit it

@murrant

This comment has been minimized.

Member

murrant commented Mar 29, 2018

Also, update the os description please.

@pheinrichs

This comment has been minimized.

Contributor

pheinrichs commented Mar 29, 2018

@murrant Consider it done,
Would you be opposed to me adding a new wireless sensor for GPS satellites?

@murrant

This comment has been minimized.

Member

murrant commented Mar 29, 2018

@pheinrichs I think the gps satellites would be more of a generic thing. Almost most any type of device could have gps in it.

@pheinrichs

This comment has been minimized.

Contributor

pheinrichs commented Apr 4, 2018

@murrant Sorry for the delay. You just meant the snmpsim description correct?
I'll just remove the GPS for now and create a new PR with a GPS state sensor that way we can review it individually.

@laf

Can you rename the mibs to drop the .mib part?

If you can also generate the json test data that would be ace.

$hardware = $device['sysDescr'];
$version = snmp_get($device, '1.3.6.1.4.1.25868.1.1.0', '-Ovqs', '');

This comment has been minimized.

@laf

laf Apr 4, 2018

Member

You can drop that last ''

@@ -0,0 +1,11 @@
os: lastmile

This comment has been minimized.

@laf

laf Apr 4, 2018

Member

This looks like it's the vendors name. The OS name needs to be what the firmware is called or if that's not possible the device / type of device.

power:
options:
divisor: 10
data:

This comment has been minimized.

@laf

laf Apr 4, 2018

Member

I'm assuming this isn't in a table? :)

This comment has been minimized.

@pheinrichs

pheinrichs Apr 4, 2018

Contributor

Boy do I wish it was...

pheinrichs and others added some commits Apr 4, 2018

Requested changes
Renamed OS
@laf

laf approved these changes Apr 7, 2018

I've just updated the test data. LGTM now.

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Apr 7, 2018

The inspection completed: No new issues

@laf laf merged commit 098c948 into librenms:master Apr 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

device: Added Last Mile CTM support (librenms#8478)
* Add Listmile mibs

Created custom lastmile mib

* Add Lastmile CTM support

* Update test description and remove wireless sensor

* Requested changes

Renamed OS

* json test data

* Updated test data

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.