New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cambium pmp ap client count discovery #8487

Merged
merged 2 commits into from Mar 30, 2018

Conversation

Projects
None yet
3 participants
@cchance27
Contributor

cchance27 commented Mar 29, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@murrant

This comment has been minimized.

Member

murrant commented Mar 29, 2018

Can you add test data for this?

  1. ./scripts/collect-snmp-data.php -v 450 -h HOSTNAME
  2. ./scripts/save-test-data.php -o pmp -v 450 -m wireless
  3. git add tests, git commit, git push

I assumed your device model is pmp-450.

@cchance27

This comment has been minimized.

Contributor

cchance27 commented Mar 30, 2018

did the requested

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 30, 2018

The inspection completed: 2 new issues, 1 updated code elements

@murrant murrant merged commit 63d6cf8 into librenms:master Mar 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

murrant added a commit to murrant/librenms that referenced this pull request Mar 30, 2018

@murrant

This comment has been minimized.

Member

murrant commented Mar 30, 2018

@cchance27 Thanks, I added the json data in #8493. I'm guessing you don't have snmpsim.

murrant added a commit that referenced this pull request Mar 30, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

Cambium pmp ap client count discovery (librenms#8487)
* Add pmp450 AP client count support

* add tests

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.