Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WTI-MPC OS and mib #8492

Merged
merged 5 commits into from Apr 1, 2018

Conversation

Projects
None yet
3 participants
@vivia11
Copy link
Contributor

vivia11 commented Mar 29, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Hello,

Adding support for wti-mpc. I've only tested with my single device, so anyone with a wti-mpc is welcome to test it.

Thank you,
Vivia

vivia11 and others added some commits Mar 26, 2018

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Mar 29, 2018

The inspection completed: No new issues

@laf

This comment has been minimized.

Copy link
Member

laf commented Mar 29, 2018

The mib for this has sensor info, are you not adding this in?

@laf laf added the Device 🖥 label Mar 29, 2018

@vivia11

This comment has been minimized.

Copy link
Contributor Author

vivia11 commented Mar 29, 2018

@laf

I've sent an email to the vendor. I only have one device and I get 0 as a value for voltage/power/current - which I find really odd. I'll add it in later if I figure out why it's giving me those values (maybe it's just my device).

If someone else has a WTI-MPC, I could add it and see what they get for values.

@laf

laf approved these changes Apr 1, 2018

Copy link
Member

laf left a comment

LGTM

@laf laf merged commit b71febf into librenms:master Apr 1, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@vivia11 vivia11 deleted the vivia11:wti-os branch Apr 3, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

device: Added WTI-MPC OS and mib (librenms#8492)
* Add icon and initial discovery

* Added more discovery for wti-mpc. Add mib.

* Add snmp data and edit discovery

* Remove discovery due to weird mib[C

* Update wti-mpc.yaml

@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.