New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lattitude and longitude on devices/device fetch #8515

Merged
merged 3 commits into from Apr 7, 2018

Conversation

Projects
None yet
2 participants
@sorribes22
Contributor

sorribes22 commented Apr 6, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

sorribes22 added some commits Apr 4, 2018

@laf

laf approved these changes Apr 7, 2018

Tested and works. Thanks @sorribes22

@laf laf merged commit c22b315 into librenms:master Apr 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@sorribes22

This comment has been minimized.

Contributor

sorribes22 commented Apr 7, 2018

A lot of thanks for you @laf . Your help was soo useful for me. This is the laravel package that I said you on discord: https://github.com/E-Ports/laravel-librenms. Its on developement and I will take some time to end it because I can't work on it every day, but some functionalities works yet.

Another time, thanks

@laf

This comment has been minimized.

Member

laf commented Apr 7, 2018

@sorribes22 Yeah I had a quick look at it earlier. I actually might use it at work as I use a laravel project which connects to the LibreNMS api.

@sorribes22

This comment has been minimized.

Contributor

sorribes22 commented Apr 8, 2018

Fine, I hope you find it useful and simple :)

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

api: Added lattitude and longitude on devices/device fetch (librenms#…
…8515)

* 'lat' and 'lng' columns added on list_devices()

* 'lat' and 'lng' columns added on device fetch

Helped by https://github.com/laf

* Commit user.name changed

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.