New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AeroHive added AP Env Temp. #8520

Merged
merged 5 commits into from Apr 9, 2018

Conversation

Projects
None yet
4 participants
@theherodied
Contributor

theherodied commented Apr 8, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@murrant

Can you please do this in YAML?

@theherodied

This comment has been minimized.

Contributor

theherodied commented Apr 8, 2018

@murrant , can you elaborate on what you mean?
I've seen the definitions in yaml but not sensors.
Can you point me to an example of some similar sensor?

@laf

This comment has been minimized.

Member

laf commented Apr 8, 2018

The discovery yaml files are in `includes/definitions/discovery/

It's in our docs as the prime example for adding sensors + you can use existing ones for support.

theherodied added some commits Apr 9, 2018

@murrant

Looks great, thanks.

One last change, update the test data.
https://docs.librenms.org/Developing/os/Test-Units/

@theherodied theherodied changed the title from Added AP Env Temp. to AeroHive added AP Env Temp. Apr 9, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Apr 9, 2018

The inspection completed: No new issues

@murrant

murrant approved these changes Apr 9, 2018

@murrant murrant merged commit 2b09332 into librenms:master Apr 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant added the Device 🖥 label Apr 9, 2018

@theherodied theherodied deleted the theherodied:theherodied-aerohive-1 branch Apr 10, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

AeroHive added AP Env Temp. (librenms#8520)
* Added AP Env Temp.

* Changed to yaml

* Corrected yaml

* Added over graphs

* Updated json test data.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.