New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict storage discovery walks to os #8528

Merged
merged 1 commit into from Apr 9, 2018

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Apr 9, 2018

leave hrstorage and ucd unrestricted
Not sure on the ilo, but I think linux and windows servers can return data

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Restrict storage discovery walks to os
leave hrstorage and ucd unrestricted
Not sure on the ilo, but I think linux and windows servers can return data
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Apr 9, 2018

The inspection completed: No new issues

@laf

This comment has been minimized.

Member

laf commented Apr 9, 2018

ilo can be windows or linux I think, might be worth restricting that to those OS'

@murrant

This comment has been minimized.

Member

murrant commented Apr 9, 2018

@laf that's what I have done.

@laf

laf approved these changes Apr 9, 2018

LGTM

@laf laf merged commit 773ee96 into librenms:master Apr 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:storage-disco branch Apr 9, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

refactor: Restrict storage discovery walks to os (librenms#8528)
leave hrstorage and ucd unrestricted
Not sure on the ilo, but I think linux and windows servers can return data

@lock lock bot locked as resolved and limited conversation to collaborators Jun 8, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.