Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Improve DCN support #8531

Merged
merged 2 commits into from Apr 9, 2018

Conversation

Projects
None yet
3 participants
@Rosiak
Copy link
Contributor

Rosiak commented Apr 9, 2018

fix #8452

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Rosiak and others added some commits Apr 9, 2018

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Apr 9, 2018

The inspection completed: No new issues

@laf

laf approved these changes Apr 9, 2018

Copy link
Member

laf left a comment

I've updated the test files to include more data + loosened the sysObjectID check.

@laf laf merged commit 7e4bae2 into librenms:master Apr 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

device: Improve DCN detection (librenms#8531)
* newdevice: Improve DCN support

fix librenms#8452

* Updated dcn-software tests

@lock lock bot locked as resolved and limited conversation to collaborators Jun 8, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.