New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devices: ibm-dpi os discovery #8541

Merged
merged 7 commits into from Apr 20, 2018

Conversation

Projects
None yet
3 participants
@vivia11
Contributor

vivia11 commented Apr 10, 2018

Hello all,

Tested with model IBM switched C19/C13 .

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

Does this have no sensors available?

Are these rebranded Eaton PDU's? Here's some info from our stats:

|Total|OS      |sysObjectID           | sysDescr |
|    4|eatonpdu|.1.3.6.1.4.1.534.6.6.7| ePDU MI 1U IN: L6-30P 24A 1P OUT: 18XC13 |
|    2|eatonpdu|.1.3.6.1.4.1.534.6.6.7| ePDU MA 36U-C IN: L21-20P 16A 3P OUT: 24x5-20R |
|    2|eatonpdu|.1.3.6.1.4.1.534.6.6.7| ePDU MA 38U-C IN: L21-20P 16A 3P OUT: 18xC13:6xC19 |
|    1|eatonpdu|.1.3.6.1.4.1.534.6.6.7| EPDU MI 38U-A IN: L21-30P 24A 3P OUT: 30XC13:6XC19:1X5-20R |
|    1|eatonpdu|.1.3.6.1.4.1.534.6.6.7|  |
|    1|generic |.1.3.6.1.4.1.534.6    | IBM DPI V0216.0002 |
@@ -0,0 +1,3 @@
<?php
$version = end(explode(' ', trim(snmp_get($device, "sysDescr.0", "-OQv", "SNMPv2-MIB"))));

This comment has been minimized.

@laf

laf Apr 10, 2018

Member

We already have sysDescr value in $device['sysDescr']

@vivia11

This comment has been minimized.

Contributor

vivia11 commented Apr 10, 2018

Mine are rebranded Lenovo PDUs actually. Maybe they're all the same now?

No MIB files that I can find. I've emailed IBM/Lenovo and hopefully they have MIBs for this (which I think they do).

@laf

This comment has been minimized.

Member

laf commented Apr 10, 2018

This might be better to call it just dpi.

@laf laf added the Device 🖥 label Apr 10, 2018

@vivia11

This comment has been minimized.

Contributor

vivia11 commented Apr 16, 2018

@laf
After some digging, this is a model that is still owned by IBM, they apparently sold the other models of this (to Lenovo) type but withdrew this one and didn't sell it.

There are also no MIBs for this, confirmed by IBM.

vivia11 added some commits Apr 16, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Apr 16, 2018

The inspection completed: 1 new issues

@laf

laf approved these changes Apr 17, 2018

LGTM

@laf laf merged commit f9da8ef into librenms:master Apr 20, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@vivia11 vivia11 deleted the vivia11:ibm-switched branch Apr 20, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

device: Added dection for ibm-dpi os (librenms#8541)
* Add ibm-dpi os support

* SNMP test data

* Remove blank space

* remove snmp_get

* Rename to dpi

* Add json test data and change text to IBM DPI

* Update json test

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.