New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AeroHive Wireless added AP130. #8543

Merged
merged 3 commits into from Apr 11, 2018

Conversation

Projects
None yet
3 participants
@theherodied
Contributor

theherodied commented Apr 10, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@theherodied

This comment has been minimized.

Contributor

theherodied commented Apr 10, 2018

Got my hands on a AP130 and tested. It works as expected.

@laf

This comment has been minimized.

Member

laf commented Apr 10, 2018

As always, can you add tests for this. Use the -v to pass a new model name over for additional test files.

@theherodied

This comment has been minimized.

Contributor

theherodied commented Apr 10, 2018

@laf, was going to but forgot. I'll add it.

theherodied added some commits Apr 11, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Apr 11, 2018

The inspection completed: No new issues

@laf

laf approved these changes Apr 11, 2018

LGTM

@laf laf merged commit e74af0a into librenms:master Apr 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

device: AeroHive Wireless added AP130. (librenms#8543)
* Added AP130.

* Added AP130 Test Data.

* Fix Test Data 001.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.