New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced old Mikrotik SWOS vendor logo with the correct Mikrotik Logo #8584

Merged
merged 4 commits into from Apr 21, 2018

Conversation

Projects
None yet
3 participants
@InsaneSplash
Contributor

InsaneSplash commented Apr 19, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Apr 21, 2018

The inspection completed: No new issues

@laf

laf approved these changes Apr 21, 2018

LGTM. Thanks for doing that @InsaneSplash

@laf laf merged commit 3500459 into librenms:master Apr 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

webui: Replaced old Mikrotik SWOS vendor logo with the correct Mikrot…
…ik Logo (librenms#8584)

* Replaced old Mikrotik SWOS vendor logo with the correct Mikrotik Logo

* Uptated RouterOS and SWOS to use a common Mikrotik logo

* Removed unused routeros.svg image file

* Updated test to use new defined icon

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2018

@InsaneSplash InsaneSplash deleted the InsaneSplash:mikrotik-swos-logo branch Jul 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.