Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite state sensors to walk entire table for TIMOS #8588

Merged
merged 2 commits into from Apr 25, 2018

Conversation

Projects
None yet
4 participants
@vivia11
Copy link
Contributor

vivia11 commented Apr 19, 2018

Hello all,
Changes to allow for entire tmnxChassisPowerSupplyTable to be processed rather than half.

Here you can see that the number of values being written to the database are doubled, as all indexes are read (on a 7210).

Tested with 7705 SAR-8 and 7210 SAS-Sx.

Here are some screenshots showing how the state table has expanded to include everything.
On a 7705 with 3 power supplies:

Master Branch
image

With Changes
image

On a 7210 SAS-Sx

Master Branch
image

With Changes
image

Let me know if this needs snmp data or any changes.

And if anyone can test this with other Nokia models, that would be awesome!

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

This comment has been minimized.

Copy link
Member

laf commented Apr 21, 2018

Thanks @vivia11 :) Can you add the test data like mentioned though, means we can ensure this stays working :D

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Apr 23, 2018

The inspection completed: No new issues

@murrant murrant merged commit 96fa9c6 into librenms:master Apr 25, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@vivia11 vivia11 deleted the vivia11:timos branch Apr 30, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

Rewrite state sensors to walk entire table for TIMOS (librenms#8588)
* Rewrite state sensors to walk entire table

* Adding test data

@lock lock bot locked as resolved and limited conversation to collaborators Jun 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.