Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Add support for HWG Poseidon 4002 #8593

Merged
merged 3 commits into from Apr 23, 2018

Conversation

Projects
None yet
3 participants
@TheGreatDoc
Copy link
Contributor

TheGreatDoc commented Apr 22, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

This comment has been minimized.

Copy link
Member

laf commented Apr 22, 2018

Thanks for this @TheGreatDoc. Just needs some test data, if you can run:

./scripts/collect-snmp-data.php -h HOSTNAME

Then add the new file to this pull request. If you want to help further, you could also install snmpsim and run the next script in the new-os docs but if not, this will do and we can finish it off.

TheGreatDoc and others added some commits Apr 22, 2018

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Apr 23, 2018

The inspection completed: No new issues

@laf

laf approved these changes Apr 23, 2018

Copy link
Member

laf left a comment

LGTM

@laf laf added the Device 🖥 label Apr 23, 2018

@laf laf merged commit aa8bc5c into librenms:master Apr 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

device: Added support for HWG Poseidon sensors (librenms#8593)
* newdevice: Add support for HWG Poseidon 4002

* Added snmprec file

* Added json test file

@lock lock bot locked as resolved and limited conversation to collaborators Jun 22, 2018

@TheGreatDoc TheGreatDoc deleted the TheGreatDoc:os_hwg-poseidon branch Aug 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.