New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update include files for disco/poller to be dynamic #8597

Merged
merged 1 commit into from Apr 25, 2018

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Apr 22, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Stops the requirement to create more if checks for files to include.

@laf laf added the Refactor label Apr 22, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Apr 22, 2018

The inspection completed: No new issues

@murrant

Looks good.

@murrant murrant merged commit 245c158 into librenms:master Apr 25, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:refactor/update-includes branch Apr 25, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.