New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New FiberHome SVG Logo #8601

Merged
merged 1 commit into from Apr 23, 2018

Conversation

Projects
None yet
3 participants
@czilian
Contributor

czilian commented Apr 23, 2018

  • replace PNG with SVG
  • adjust testing json data to *.svg
    (fiberhome_switch and fiberhome)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

New FiberHome SVG Logo
- replace PNG with SVG
- adjust testing json data to *.svg
  (fiberhome_switch and fiberhome)
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Apr 23, 2018

The inspection completed: No new issues

@laf

laf approved these changes Apr 23, 2018

LGTM

@laf laf merged commit fa035be into librenms:master Apr 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf added the WebUI label Apr 23, 2018

@czilian

This comment has been minimized.

Contributor

czilian commented Apr 24, 2018

@laf thx laf for your patience with a twice a year contributor.

@czilian czilian deleted the czilian:newFHlogo branch Apr 24, 2018

@laf

This comment has been minimized.

Member

laf commented Apr 24, 2018

@czilian That's better than 0 times a year :)

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

New FiberHome SVG Logo (librenms#8601)
- replace PNG with SVG
- adjust testing json data to *.svg
  (fiberhome_switch and fiberhome)

@lock lock bot locked as resolved and limited conversation to collaborators Jun 23, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.