New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a third graph to unbound with more metrics #8616

Merged
merged 5 commits into from Apr 25, 2018

Conversation

Projects
None yet
5 participants
@hanserasmus
Contributor

hanserasmus commented Apr 25, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@hanserasmus

This comment has been minimized.

Contributor

hanserasmus commented Apr 25, 2018

Is there something I could do about the failed checks in Travis? Not sure what failed or why, but I'm more than willing to change anything that needs changing from my end.

'rcodeNXDOMAIN' => $unbound['num.answer.rcode.NXDOMAIN'],
'rcodeNodata' => $unbound['num.answer.rcode.nodata']
);
$metrics['operations'] = $fields;

This comment has been minimized.

@murrant

murrant Apr 25, 2018

Member

You need to merge the arrays here:

$metrics += $fields;

This comment has been minimized.

@hanserasmus

hanserasmus Apr 25, 2018

Contributor

Done. Is this correct?

This comment has been minimized.

@murrant

murrant Apr 25, 2018

Member

I was wrong :)

hanserasmus added some commits Apr 25, 2018

@f0o

This comment has been minimized.

Member

f0o commented Apr 25, 2018

Why all the whitespace/newline changes?

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Apr 25, 2018

The inspection completed: No new issues

@laf

laf approved these changes Apr 25, 2018

LGTM

@laf laf merged commit 163c595 into librenms:master Apr 25, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

feature: Added a third graph to unbound with more metrics (librenms#8616
)

* Added a third graph to unbound with more metrics

* Update unbound.inc.php

* Reset composer.lock

* Update unbound.inc.php

* Update unbound.inc.php

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.