New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sysObjectID for Canon LBP printer series #8644

Merged
merged 3 commits into from May 7, 2018

Conversation

Projects
None yet
6 participants
@githubuserx
Contributor

githubuserx commented May 1, 2018

I mentioned missing Canon LBP series printers some time ago in issue #5637, but didn't find the time to submit a PR until now. There also seems to be an additional OID (.1.3.6.1.4.1.1602.4.3) assigned to Canon printers, but I didn't include it since I don't have matching devices to test with.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant

This comment has been minimized.

CLAassistant commented May 1, 2018

CLA assistant check
All committers have signed the CLA.

@Rosiak

This comment has been minimized.

Contributor

Rosiak commented May 2, 2018

Hi there,

Could you please add test data to this PR?(https://docs.librenms.org/#Developing/os/Test-Units/)
Thanks!

@githubuserx

This comment has been minimized.

Contributor

githubuserx commented May 3, 2018

I am not exactly sure whats needed for testing, would the output of ./scripts/collect-snmp-data.php be sufficient? and where would I add it? The script creates a new file canonprinter.snmprec, but there are already more specific ones - e.g. canonprinter-lbp.snmprec. Since my PR only concerns the LBP series should I just append the output to this one? I set the os variant to LBP and now it's appended to the corresponding file. Thanks!

btw: I only have a LBP 6650 and a LBP 6670 and so far everything seems to work as expected.

@murrant

This comment has been minimized.

Member

murrant commented May 5, 2018

yes, if you add the .snmprec file from ./scripts/collect-snmp-data.php I can generate the json.

If you've already generated this file you need to add it to this pull request still.

@githubuserx

This comment has been minimized.

Contributor

githubuserx commented May 5, 2018

Sorry for the delay, I've added now the output of the snmprec script with IPs, MAC and serial number redacted. Please let me know if you need anything else.

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented May 6, 2018

The inspection completed: No new issues

@murrant

murrant approved these changes May 7, 2018

@murrant

This comment has been minimized.

Member

murrant commented May 7, 2018

Thanks @githubuserx nice work.

@murrant murrant merged commit 9401e43 into librenms:master May 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

Added sysObjectID for Canon LBP printer series (librenms#8644)
* Added sysObjectID for Canon LBP printer series, previously mentioned in issue (librenms#5637)

* Added snmprec data for Canon LBP6670 (librenms#5637)

* Create canonprinter_lbp.json

@laf laf added the Device 🖥 label May 30, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.