New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reordering metrics list on Health-Information doc #8653

Merged
merged 7 commits into from May 2, 2018

Conversation

Projects
None yet
4 participants
@k-y
Contributor

k-y commented May 2, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

k-y and others added some commits Apr 27, 2018

@k-y

This comment has been minimized.

Contributor

k-y commented May 2, 2018

This is a documentation update only. Realized the list of metrics was no longer ordered alphabetically when discussing a change on Discord.

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented May 2, 2018

The inspection completed: No new issues

@murrant

murrant approved these changes May 2, 2018

Thanks :)

@murrant murrant merged commit 4140796 into librenms:master May 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

Reordering metrics list on Health-Information doc (librenms#8653)
* Updated XIRRUS-MIB; added Temperature

* Corrected field and indentation

* Added test data

* More test data

* Create xirrus_aos.json

* Reordered metrics back into alphabetical

@lock lock bot locked as resolved and limited conversation to collaborators Jul 1, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.