New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snmpscan.py: ignore bad DNS config #8656

Merged
merged 1 commit into from May 4, 2018

Conversation

Projects
None yet
2 participants
@murrant
Member

murrant commented May 2, 2018

When someone has configured reverse dns that points to an incorrect dns hostname, this should revert to IP properly

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

snmpscan.py: ignore bad DNS config
When someone has configured reverse dns that points to an incorrect dns hostname, this should revert to IP properly
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented May 2, 2018

The inspection completed: No new issues

@murrant murrant merged commit e1a3533 into librenms:master May 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant added the Bug 🐞 label May 4, 2018

@laf laf deleted the murrant:ignore-dns-error-snmpscan branch May 7, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

snmpscan.py: ignore bad DNS config (librenms#8656)
When someone has configured reverse dns that points to an incorrect dns hostname, this should revert to IP properly

@lock lock bot locked as resolved and limited conversation to collaborators Jul 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.