Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for get_alert API method. #8658

Merged
merged 1 commit into from May 5, 2018

Conversation

Projects
None yet
4 participants
@angryp
Copy link
Contributor

angryp commented May 3, 2018

Fix for get_alert API method. Tested on MySQL-community 5.7.22 and MariaDB 10.2.14.
Issue log sample:
2018-05-02 07:10:44 MySQL Error: Column 'id' in where clause is ambiguous (SELECT D.hostname, A.*, R.severity FROM alerts AS A, devices AS D, alert_rules AS R WHERE D.device_id = A.device_id AND A.rule_id = R.id AND A.state IN ('1') AND id='31731')

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented May 3, 2018

CLA assistant check
All committers have signed the CLA.

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented May 3, 2018

The inspection completed: No new issues

@murrant

murrant approved these changes May 5, 2018

@murrant

This comment has been minimized.

Copy link
Member

murrant commented May 5, 2018

Thanks 💯

@murrant murrant merged commit 82072b3 into librenms:master May 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant added the Bug 🐞 label May 5, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jul 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.