New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue Coat device updates #8664

Merged
merged 8 commits into from May 13, 2018

Conversation

Projects
None yet
3 participants
@centralscrutiniser
Contributor

centralscrutiniser commented May 5, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

  • Updated SGOS graph generation to include Server/Client Connections
  • Added SQL schema file for new Blue Coat graphs.
  • Updated Blue Coat Packetshaper YAML file, and included latest S-Series MIB
  • Updated BLUECOAT-MIB for newer device hardware detection
  • Added SSL Visibility YAML file for OS detection

centralscrutiniser added some commits May 5, 2018

$colour_area_max = '9999cc';
//$graph_max = 1;

This comment has been minimized.

@laf

laf May 7, 2018

Member

Delete these lines if they aren't being used.

This comment has been minimized.

@centralscrutiniser

centralscrutiniser May 7, 2018

Contributor

Will do.

- sysDescr:
- PacketShaper
- sysObjectID:
- .1.3.6.1.4.1.14501.11.1.1

This comment has been minimized.

@laf

laf May 7, 2018

Member

According to our test data this will also need:

.1.3.6.1.4.1.2334.1.1.

You probably should also change .1.3.6.1.4.1.14501.11.1.1 to .1.3.6.1.4.1.14501.11.1.

This comment has been minimized.

@centralscrutiniser

centralscrutiniser May 7, 2018

Contributor

Hi @laf, .1.3.6.1.4.1.2334.1.1 old Packetshaper (EOL models). The newer S-Series appliances don't support this OID.

This comment has been minimized.

@laf

laf May 8, 2018

Member

Doesn't matter if it's EOL. We have people who use them still as they show up in our stats so they need to be supported.

This comment has been minimized.

@centralscrutiniser

centralscrutiniser May 8, 2018

Contributor

@laf Thanks for the comment. Would welcome your suggestions on fixing the fact that the S-Series Packetshaper are detected as Generic.

ps.

If the YAML file is changed, it's correctly detected.

This comment has been minimized.

@laf

laf May 8, 2018

Member

Changed to what though? Show what it is you've tried.

This comment has been minimized.

@centralscrutiniser

centralscrutiniser May 8, 2018

Contributor

On an amended LibreNMS install (live), it displays as -

screen shot 2018-05-08 at 22 49 05

The YAML file is -

os: packetshaper
text: 'Blue Coat PacketShaper'
type: network
ifname: 1
icon: bluecoat
mib_dir:
- bluecoat
over:
- { graph: device_bits, text: 'Device Traffic' }
discovery:
- sysObjectID:
- .1.3.6.1.4.1.14501.11.1.1

This comment has been minimized.

@laf

laf May 9, 2018

Member

Those don't look like they are being detected as generic, just the logo didn't show in the first one.

This comment has been minimized.

@centralscrutiniser

centralscrutiniser May 11, 2018

Contributor

Hi @laf thats the point. With the S-Series appliances, the original packetshaper.yaml file doesn't match the appliance and thus change the logo (it shows as generic), but it is a Packetshaper. We have an older PS1400 in our lab, I'll test the file against this also, as it would cover both old and new.

@@ -0,0 +1,14 @@
os: sslvis
text: 'Blue Coat SSL Visibility'

This comment has been minimized.

@laf

laf May 7, 2018

Member

What is this device?

This comment has been minimized.

@centralscrutiniser

centralscrutiniser May 7, 2018

Contributor

Hi @laf This is a new appliance formed as part of Blue Coat's portfolio when they purchased Netronome Syetems in 2016.

This comment has been minimized.

@laf

laf May 8, 2018

Member

Any links to it online?

This comment has been minimized.

$hostname = trim(snmp_get($device, "SNMPv2-MIB::sysName.0", "-OQv"), '"');
$sgos_requests = snmp_get($device, "BLUECOAT-SG-PROXY-MIB::sgProxyHttpClientRequestRate.0", "-OQvU");
$oid_list = 'sgProxyVersion.0 sgProxySoftware.0 sgProxyHttpClientRequestRate.0 sgProxyHttpClientConnections.0 sgProxyHttpClientConnectionsActive.0 sgProxyHttpClientConnectionsIdle.0 sgProxyHttpServerConnections.0 sgProxyHttpServerConnectionsActive.0 sgProxyHttpServerConnectionsIdle.0';
$sgos = snmp_get_multi($device, $oid_list, '-OUQs', 'BLUECOAT-SG-PROXY-MIB');

This comment has been minimized.

@laf

laf May 7, 2018

Member

You can probably change this to snmp_get_multi_oid

echo ' HTTP Req Rate';
}
if (is_numeric($sgos[0]['sgProxyHttpClientConnections'])) {

This comment has been minimized.

@laf

laf May 7, 2018

Member

If these are all new defs then you'll have to create a new file for them, you can't add additional defs without dumping and re-importing the rrd file.

This comment has been minimized.

@centralscrutiniser

centralscrutiniser May 8, 2018

Contributor

HI @laf I'm not sure I understand you on this. The new OID objects in this file create new graphs under the network section of the device. The inc files I added under html/includes/graphs/device/ deal with getting the data and displaying those RRD's. It doesn't affect the existing RRD for HTTP requests.

This comment has been minimized.

@laf

laf May 8, 2018

Member

Are these new OIDs just being added to the existing rrd file? If so, you can't do that and will need to create a new file with them in.

This comment has been minimized.

@centralscrutiniser

centralscrutiniser May 8, 2018

Contributor

@laf No, the new OIDs are sent to different RRD files. Like so -

sgos_client_connections_active.rrd
sgos_client_connections_idle.rrd
sgos_client_connections.rrd
sgos_server_connections_active.rrd
sgos_server_connections_idle.rrd
sgos_server_connections.rrd

In a live deployment, they generate output like so under the 'Network' section of the ProxySG -

screen shot 2018-05-08 at 21 58 45

This comment has been minimized.

@laf

laf May 8, 2018

Member

Ok thanks for clarifying.

centralscrutiniser added some commits May 8, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented May 8, 2018

The inspection completed: No new issues

@laf

laf approved these changes May 13, 2018

LGTM. Just waiting on final checks to pass.

@laf laf merged commit ba0ed73 into librenms:master May 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@centralscrutiniser centralscrutiniser deleted the centralscrutiniser:bluecoat-updates branch May 13, 2018

@centralscrutiniser centralscrutiniser restored the centralscrutiniser:bluecoat-updates branch May 14, 2018

@centralscrutiniser

This comment has been minimized.

Contributor

centralscrutiniser commented May 14, 2018

Hi @laf had to re-open this. I've found an issue with the sgos.inc.php file and using snmp_get_multi_oid. It doesn't create the RRD's.

Also, the definitions.inc.php file is missing the new graph types for display under the device/ network section, which is strange, as I thought I'd committed this sometime ago.

Some of the RRD's also have typos.

Also, minor typo on HTTP Server Connection Active (typo = Acitve).

Really sorry! Should have tested this better! Fixes coming shortly.

@centralscrutiniser centralscrutiniser deleted the centralscrutiniser:bluecoat-updates branch May 14, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

device: Added and Updated Blue Coat device support (librenms#8664)
* Blue Coat device updates

* Blue Coat device updates

* Updated PHP code per @laf comments

* YAML update for Packetshaper

* SSL Visibility YAML and snmprec file

* Cleanup problematic MIB files which should not have been there

* Reset Packetshaper YAML to original

* Added json test data

@laf laf added the Device 🖥 label May 30, 2018

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

device: Added and Updated Blue Coat device support (librenms#8664)
* Blue Coat device updates

* Blue Coat device updates

* Updated PHP code per @laf comments

* YAML update for Packetshaper

* SSL Visibility YAML and snmprec file

* Cleanup problematic MIB files which should not have been there

* Reset Packetshaper YAML to original

* Added json test data

@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.