New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also include adsl stats for vdsl ports #8670

Merged
merged 2 commits into from May 21, 2018

Conversation

Projects
None yet
3 participants
@robje
Contributor

robje commented May 7, 2018

my vigor 130 modem has adsl counters for the vdsl port.
include polling for those counters

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

This comment has been minimized.

Member

laf commented May 7, 2018

Kicked travis, hopefully it will complete

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented May 7, 2018

The inspection completed: No new issues

@laf laf dismissed their stale review via 43f6378 May 13, 2018

@laf

This comment has been minimized.

Member

laf commented May 13, 2018

Made a small change to kick travis again.

@laf

laf approved these changes May 13, 2018

LGTM

@laf laf merged commit 82d01eb into librenms:master May 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf added the Feature label May 30, 2018

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

feature: Include adsl stats for vdsl ports (librenms#8670)
* also include adsl stats for vdsl ports

* Update ports.inc.php

@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.