New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore OpenBSD version/features/hardware #8673

Merged
merged 3 commits into from May 9, 2018

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented May 8, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@murrant murrant added the Bug 🐞 label May 8, 2018

@laf

laf approved these changes May 8, 2018

php > $test = '(boom)';
php > print_r(str_replace(['(',')'], '', $test));
boom

Just shortened the str_replace() usage.

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented May 8, 2018

The inspection completed: No new issues

@murrant

This comment has been minimized.

Member

murrant commented May 9, 2018

You fixed my copy pasta.

@murrant murrant merged commit b94ad92 into librenms:master May 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:openbsd-os branch May 9, 2018

laf added a commit that referenced this pull request May 9, 2018

laf added a commit that referenced this pull request May 9, 2018

Revert "Add check_http service custom command" (#8680)
* Revert "device: Add NTP support for Allied Telesis AWPlus products (#8580)"

This reverts commit e898075.

* Revert " Restore OpenBSD version/features/hardware (#8673)"

This reverts commit b94ad92.

* Revert "Expand the description of Application support (#8619)"

This reverts commit 8ce423d.

* Revert "Documentation updates for DMI support and making two links in the FAQ work (#8440)"

This reverts commit a7437c1.

* Revert "webui: Make two-factor auth logo use response (#8652)"

This reverts commit 3e0c26f.

* Revert "fix: Updated Discovery on Ceragon to re-add wireless (#8647)"

This reverts commit ce2b9f9.

* Revert "feature: Add check_http service custom command (#8675)"

This reverts commit a1f92a9.

kkrumm1 added a commit that referenced this pull request May 9, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

Restore OpenBSD version/features/hardware (librenms#8673)
* Restore OpenBSD version/features/hardware

* Add os test data

* Update openbsd.inc.php

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

Revert "Add check_http service custom command" (librenms#8680)
* Revert "device: Add NTP support for Allied Telesis AWPlus products (librenms#8580)"

This reverts commit e898075.

* Revert " Restore OpenBSD version/features/hardware (librenms#8673)"

This reverts commit b94ad92.

* Revert "Expand the description of Application support (librenms#8619)"

This reverts commit 8ce423d.

* Revert "Documentation updates for DMI support and making two links in the FAQ work (librenms#8440)"

This reverts commit a7437c1.

* Revert "webui: Make two-factor auth logo use response (librenms#8652)"

This reverts commit 3e0c26f.

* Revert "fix: Updated Discovery on Ceragon to re-add wireless (librenms#8647)"

This reverts commit ce2b9f9.

* Revert "feature: Add check_http service custom command (librenms#8675)"

This reverts commit a1f92a9.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 8, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.