New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alerting with dynamic contacts for rules made with the new builder #8677

Merged
merged 1 commit into from May 8, 2018

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented May 8, 2018

Update test-alert.php too

Thanks to @dsgagi on Discord for identifying the issue

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fix alerting with dynamic contacts made with the new builder
Update test-alert.php too

Thanks to @dsgagi on Discord for identifying the issue

@murrant murrant changed the title from Fix alerting with dynamic contacts made with the new builder to Fix alerting with dynamic contacts for rules made with the new builder May 8, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented May 8, 2018

The inspection completed: No new issues

@laf

laf approved these changes May 8, 2018

Tested ok.

@laf laf merged commit 350b3a1 into librenms:master May 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:fix-alert-contacts branch May 8, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

fix: Fixed alerting with dynamic contacts for rules made with the new…
… builder (librenms#8677)

Update test-alert.php too

Thanks to @dsgagi on Discord for identifying the issue

@lock lock bot locked as resolved and limited conversation to collaborators Jul 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.