New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update juniper junos chassis definitions #8678

Merged
merged 1 commit into from May 8, 2018

Conversation

Projects
None yet
4 participants
@nwautomator
Contributor

nwautomator commented May 8, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant

This comment has been minimized.

CLAassistant commented May 8, 2018

CLA assistant check
All committers have signed the CLA.

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented May 8, 2018

The inspection completed: No new issues

@nwautomator

This comment has been minimized.

Contributor

nwautomator commented May 8, 2018

@laf

laf approved these changes May 8, 2018

LGTM.

In general the junos dir needs a big cleanup

@laf laf merged commit 89092cd into librenms:master May 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

@laf laf added the Device 🖥 label May 30, 2018

laf added a commit that referenced this pull request Jul 23, 2018

Changed jnxProductQFX511048S4Q to jnxProductQFX511048S4C in rewrites.…
…php (#8932)

Originally had this pull request earlier this year to add support for this: #8466 but looks like Juniper changed this at some point when the Juniper chassis mibs were updated here: #8678

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [ X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.