New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Barracuda Spam Firewall product name with the current name (Barracuda Email Security Gateway) #8682

Merged
merged 5 commits into from May 24, 2018

Conversation

Projects
None yet
3 participants
@salt-lick
Contributor

salt-lick commented May 9, 2018

New product name change confirmed via Barracuda chat on May 9, 2018
I plan on extending this a bit further but I'll submit a pull for that later.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Updated with the new product name
New product name change confirmed via Barracuda chat on May 9, 2018
I plan on extending this a bit further but I'll submit a pull for that later.
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented May 9, 2018

The inspection completed: No new issues

@laf

This comment has been minimized.

Member

laf commented May 9, 2018

@salt-lick Do you have test data for this?

@laf laf added the Needs Tests 🦄 label May 9, 2018

@salt-lick salt-lick changed the title from Updated with the new product name to Update Barracuda Spam Firewall product name with the current name (Barracuda Email Security Gateway) May 9, 2018

@salt-lick

This comment has been minimized.

Contributor

salt-lick commented May 22, 2018

'Should be all you need ( Barracuda name change test data ) '
If I need to strip out anything else... let me know, please.

^^^^ derped

@laf

This comment has been minimized.

Member

laf commented May 23, 2018

You need to add it to this PR :) If you could rebase it as well that would be good.

@laf

This comment has been minimized.

Member

laf commented May 24, 2018

Can you run this:

./scripts/collect-snmp-data.php -h $hostname -v email_sg

@salt-lick

Let me know if I need to run anything else.

@laf

This comment has been minimized.

Member

laf commented May 24, 2018

Thanks for pushing that. I've added the relevant json test data.

FYI for the future, you can't alter OIDs to be non-numeric so .X.X.X.X isn't valid. I removed those lines.

@laf laf added Device 🖥 and removed Needs Tests 🦄 labels May 24, 2018

@laf

laf approved these changes May 24, 2018

LGTM

@laf laf merged commit cb9077a into librenms:master May 24, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@lock lock bot locked as resolved and limited conversation to collaborators Jul 23, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.