New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature to filter delayed alerts on widget #8704

Merged
merged 4 commits into from May 15, 2018

Conversation

Projects
None yet
4 participants
@DR3EVR8u8c
Contributor

DR3EVR8u8c commented May 12, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

my work place is used to zenoss’ way to display warning and critical in different colors and events only turn critical after retries and delayed. when I introduce librenms, they feel strongly against the alert widget and alerts panel due to librenms has different concept of warning and different ways of alert.

Since my colleagues are used to watch display screen instead of email or other transporter, it is big concern for them if false/non-confirmed alerts keep showing on the dashboard. Although I have gone through the librenms performance tips and followed the procedures, we are still getting false alerts for Device up/down. Therefore, I decided to customize the display and only show delayed alerts, which is confirmed and sure.

I have made the changes on alert widget and it is working as expected so far. I thought someone else may want this feature as well.

@CLAassistant

This comment has been minimized.

CLAassistant commented May 12, 2018

CLA assistant check
All committers have signed the CLA.

@DR3EVR8u8c

This comment has been minimized.

Contributor

DR3EVR8u8c commented May 12, 2018

have fixed the build job error, please pull again

@murrant

This comment has been minimized.

Member

murrant commented May 12, 2018

Looks ok to me. My only concern is the setting name, "Delayed alerts" doesn't seem very clear to me.

@DR3EVR8u8c

This comment has been minimized.

Contributor

DR3EVR8u8c commented May 13, 2018

@DR3EVR8u8c

This comment has been minimized.

Contributor

DR3EVR8u8c commented May 13, 2018

Hello,
I have been thinking the name today and I am wondering if "fired alerts" feel more senses than that. just want to know your opinions before I go ahead to push up to the github.
Cheers,
Roger

@laf

This comment has been minimized.

Member

laf commented May 13, 2018

Triggered alerts?

@DR3EVR8u8c

This comment has been minimized.

Contributor

DR3EVR8u8c commented May 13, 2018

Fired alerts ?
Triggered alerts seems not clear as well.

@laf

This comment has been minimized.

Member

laf commented May 14, 2018

Fired alerts ?
Triggered alerts seems not clear as well.

Is fine with me.

@laf

laf approved these changes May 15, 2018

LGTM

@laf laf merged commit e22642c into librenms:master May 15, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

feature: Added feature to filter delayed alerts on widget (librenms#8704
)

* Added feature to filter delayed alerts on widget

* fix build job error

* change filter name to fired

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

feature: Added feature to filter delayed alerts on widget (librenms#8704
)

* Added feature to filter delayed alerts on widget

* fix build job error

* change filter name to fired

@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.