New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated MySQL entry. #8708

Merged
merged 2 commits into from May 14, 2018

Conversation

Projects
None yet
3 participants
@theherodied
Contributor

theherodied commented May 14, 2018

Cleaned up MySQL entry. Had somewhat duplicated Agent entries that might cause confusion. One was before the snmp extend entry, and the other after. This might cause people to believe both are needed. I cleaned it up and merged the agent entries.

Added comment at top to clarify that only one detection method is needed.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Updated MySQL entry.
Cleaned up MySQL entry. Had somewhat duplicated Agent entries that might cause confusion. One was before the snmp extend entry, and the other after. This might cause people to believe both are needed. I cleaned it up and merged the agent entries.

Added comment at top to clarify that only one detection method is needed.

@kkrumm1 kkrumm1 changed the title from Updated MySQL entry. to docs: Updated MySQL entry. May 14, 2018

@laf

laf approved these changes May 14, 2018

@laf laf merged commit a2e68f4 into librenms:master May 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

docs: Updated MySQL application entry for clarification. (librenms#8708)
* Updated MySQL entry.

Cleaned up MySQL entry. Had somewhat duplicated Agent entries that might cause confusion. One was before the snmp extend entry, and the other after. This might cause people to believe both are needed. I cleaned it up and merged the agent entries.

Added comment at top to clarify that only one detection method is needed.

* Fixed highlighting

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

docs: Updated MySQL application entry for clarification. (librenms#8708)
* Updated MySQL entry.

Cleaned up MySQL entry. Had somewhat duplicated Agent entries that might cause confusion. One was before the snmp extend entry, and the other after. This might cause people to believe both are needed. I cleaned it up and merged the agent entries.

Added comment at top to clarify that only one detection method is needed.

* Fixed highlighting

@lock lock bot locked as resolved and limited conversation to collaborators Jul 13, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.