New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with globals #8709

Merged
merged 1 commit into from May 14, 2018

Conversation

Projects
None yet
2 participants
@murrant
Member

murrant commented May 14, 2018

Some variables aren't global anymore.
Make $vars global.

Wasn't able to test these changes.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fix some issues with globals
Some variables aren't global anymore.
Make $vars global.
@laf

This comment has been minimized.

Member

laf commented May 14, 2018

@murrant Does this fix the cbqos issue, was just looking at that?

@murrant

This comment has been minimized.

Member

murrant commented May 14, 2018

Yes, it uses global $vars inside a function.

@laf

laf approved these changes May 14, 2018

LGTM

@laf laf merged commit 9e30d3f into librenms:master May 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:fix-globals branch May 14, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

Fix some issues with globals (librenms#8709)
Some variables aren't global anymore.
Make $vars global.

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

Fix some issues with globals (librenms#8709)
Some variables aren't global anymore.
Make $vars global.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 13, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.