New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alerting: Updated variables available for templates #8713

Merged
merged 1 commit into from May 16, 2018

Conversation

Projects
None yet
2 participants
@laf
Member

laf commented May 14, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

This adds some more fields to the templates as request by users (alert notes + device icmp performance stats).

For icmp stats, we check that the device has icmp enabled and it's not disabled globally and then grab the data.

@laf laf added the Alerting 🔔 label May 14, 2018

@murrant murrant merged commit d7899f5 into librenms:master May 16, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:issue-8353-template-vars branch May 19, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jul 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.