New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up old cambium code / migrate more data to wireless sensors #8725

Merged
merged 3 commits into from Jun 13, 2018

Conversation

Projects
None yet
2 participants
@pheinrichs
Contributor

pheinrichs commented May 16, 2018

I would very much prefer testers for this PR. I bit of old code so I want to verifiy nothing funny is happening for anyone. On my local dev machine it looks all okay after a week of testing.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

pheinrichs added some commits May 16, 2018

@laf

This comment has been minimized.

Member

laf commented May 19, 2018

Looks ok to me but we'll have to notify users that they will lose historical data (I realise the graph will still show the old data but we should still tell people).

Any reason the OS polling files have been removed?

@pheinrichs

This comment has been minimized.

Contributor

pheinrichs commented May 22, 2018

The Cambium / Canopy OS's don't exist anymore. They were split into pmp, ptp, cmm, etc. So those polling files weren't really doing anything, along with there corresponding sensor files.

@laf

This comment has been minimized.

Member

laf commented May 23, 2018

If you can chuck a notice up like you did here https://github.com/librenms/librenms.github.io/pull/99/files just explaining that the data is going to move elsewhere then we can merge this in.

@pheinrichs

This comment has been minimized.

Contributor

pheinrichs commented May 28, 2018

Notification PR sent: librenms/librenms.github.io#101

@laf laf added Device 🖥 and removed Needs Testing labels May 31, 2018

@laf laf added this to the 1.41 milestone May 31, 2018

@laf

This comment has been minimized.

Member

laf commented May 31, 2018

Notification merged.

/remind me next Monday to merge this in

@laf

laf approved these changes Jun 13, 2018

LGTM.

@laf

This comment has been minimized.

Member

laf commented Jun 13, 2018

Was very late merging this in :(

@laf laf merged commit 05c03a2 into librenms:master Jun 13, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

Clean up old cambium code / migrate more data to wireless sensors (li…
…brenms#8725)

* Clean up old cambium code / migrate more data to wireless sensors

Update tests

* Fix tests

* Update 450m tests

@lock lock bot locked as resolved and limited conversation to collaborators Aug 12, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.