New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hostname lookup for distributed poller on some platforms #8727

Merged
merged 1 commit into from May 19, 2018

Conversation

Projects
None yet
2 participants
@murrant
Member

murrant commented May 16, 2018

May cause warnings about poller not polling if the name doesn't match exactly as the old one.
Just delete from /pollers

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fix hostname lookup for distributed poller on some platforms
May cause warnings about poller not polling if the name doesn't match exactly as the old one.
Just delete from /pollers
@laf

laf approved these changes May 19, 2018

LGTM

php > var_dump(php_uname('n'));
php shell code:1:
string(17) "web01.1.novalocal"
php > var_dump(trim(file_get_contents('/proc/sys/kernel/hostname')));
php shell code:1:
string(17) "web01.1.novalocal"

@laf laf merged commit 99c7456 into librenms:master May 19, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:php-uname branch May 19, 2018

@laf laf added the Bug 🐞 label May 30, 2018

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

fix: Fixed hostname lookup for distributed poller on some platforms (l…
…ibrenms#8727)

May cause warnings about poller not polling if the name doesn't match exactly as the old one.
Just delete from /pollers

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.