New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated installation instructions #8733

Merged
merged 6 commits into from May 17, 2018

Conversation

Projects
None yet
3 participants
@hanserasmus
Contributor

hanserasmus commented May 17, 2018

Added a few steps I think might be useful to first time Libre users.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Updated CentOS (Apache) installation instructions
Added a few steps I think might be useful to first time Libre users.
@@ -108,7 +108,7 @@ Install the policy tool for SELinux:
setsebool -P httpd_can_sendmail=1
##### Allow fping
Create the file http_fping.tt with the following contents:
Create the file http_fping.tt with the following contents. You can create this file anywhere, as it is a throw-away file. The last step in this install procedure will install the module in the proper location.

This comment has been minimized.

@murrant

murrant May 17, 2018

Member

This needs to be copied to the nginx install docs too.

This comment has been minimized.

@hanserasmus

hanserasmus May 17, 2018

Contributor

I'll go edit that as well, and create PR for it.

@@ -138,6 +138,12 @@ Then run these commands
#### Configure snmpd
Create a backup of your old snmpd.conf that shipped with your CentOS install.

This comment has been minimized.

@murrant

murrant May 17, 2018

Member

Not sure this is needed, if users want the default config back, they can just reinstall snmp.

@@ -171,6 +177,11 @@ Now head to the web installer and follow the on-screen instructions.
http://librenms.example.com/install.php
The web installer will prompt you to create a `config.php` file in your librenms install location. Please remember to set the permissions on config.php after you copied the on-screen contents to the file. Run:

This comment has been minimized.

@murrant

murrant May 17, 2018

Member

This is definitely not needed. It is ok for the config.php file to have different permissions, as long as the web server can read it, and it definitely can since it wrote it.

Sure, validate.php will complain about it, but that is minor.

This comment has been minimized.

@hanserasmus

hanserasmus May 17, 2018

Contributor

This is needed IMHO. During my CentOS install the web installer complained it could not create a config.php file. It asked to manually copy the content of the text displayed on-screen to a file called config.php. This has happened on every CentOS install for me. But maybe my install is screwed.
Seeing as we run commands as root, the config.php file will then be created as root. Making it non-readable to apache/librenms, isn't it?

This comment has been minimized.

@murrant

murrant May 17, 2018

Member

Yeah, web server has trouble making that file because of permissions and we can't fix the permissions for that folder because it would mess up permissions.

Maybe reword the note to say, if you need to manually create this file, make sure to chown it, or something like that.

hanserasmus added a commit to hanserasmus/librenms that referenced this pull request May 17, 2018

hanserasmus added some commits May 17, 2018

@murrant murrant changed the title from Updated CentOS (Apache) installation instructions to Updated installation instructions May 17, 2018

@murrant murrant merged commit 70857e5 into librenms:master May 17, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@hanserasmus hanserasmus deleted the hanserasmus:patch-5 branch May 17, 2018

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

Updated installation instructions (librenms#8733)
* Updated CentOS (Apache) installation instructions

Added a few steps I think might be useful to first time Libre users.

* Update Installation-CentOS-7-Apache.md

* Added proposed changes from the comments sections

* Update Installation-CentOS-7-Nginx.md

* Update Installation-Ubuntu-1604-Apache.md

* Update Installation-Ubuntu-1604-Nginx.md

@lock lock bot locked as resolved and limited conversation to collaborators Jul 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.